Skip to content

Fix type declaration error or antd.Slider.value#50

Merged
Col0ring merged 3 commits intomodelscope:mainfrom
PatZer0:patch-1
Feb 10, 2025
Merged

Fix type declaration error or antd.Slider.value#50
Col0ring merged 3 commits intomodelscope:mainfrom
PatZer0:patch-1

Conversation

@PatZer0
Copy link
Copy Markdown
Contributor

@PatZer0 PatZer0 commented Feb 6, 2025

Close: #49

修改value的声明为value: int | float | list[int | float] | None = None,后问题解决。
image

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: 2cbfb8b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Col0ring
Copy link
Copy Markdown
Collaborator

Col0ring commented Feb 7, 2025

感谢 pr,不过这个类型确实应该是 tuple 哈,range 模式的 value 最多也只能接收 [int, int] 这样的 list,应该再加一个 list 的类型做兼容就行,原来的 tuple 定义还是需要留着的。

@Col0ring Col0ring merged commit 6803034 into modelscope:main Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

antd.Slider的value参数类型声明不正确

2 participants